Re: Enhance file_fdw to report processed and skipped tuples in COPY progress

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Enhance file_fdw to report processed and skipped tuples in COPY progress
Date: 2024-11-30 06:23:08
Message-ID: CALdSSPjMpL1sYgSLFFhmJx4e186U3_Fq7=32od=HRTFMnnnJDQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 11 Oct 2024 at 06:53, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> However, this issue already exists without the proposed patch.
> Since file_fdw already reports progress partially, querying multiple
> file_fdw tables can lead to inaccurate or confusing progress reports.
> You can even observe this when analyzing a file_fdw table and also
> when copying to the table with a trigger that executes progress-reporting
> commands.
>
> So, I don’t think this issue should block the proposed patch.
> In fact, progress reporting is already flawed in these scenarios,
> regardless of whether the patch is applied.

Im +1 on this. To include or not to include these new fields, and to
fix multiple-run-bug is two separate topics IMO.
Also please notice review comments in[0].

[0] https://www.postgresql.org/message-id/20241011153645.a348de1576a3f57092c68355%40sraoss.co.jp

Moved to the next CF.

--
Best regards,
Kirill Reshke

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-11-30 06:50:20 Re: UUID v7
Previous Message Kirill Reshke 2024-11-30 04:48:22 Re: Vacuum statistics