| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | Yushi Ogiwara <btogiwarayuushi(at)oss(dot)nttdata(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix for consume_xids advancing XIDs incorrectly |
| Date: | 2024-12-03 09:28:33 |
| Message-ID: | CALdSSPix0UFXTHwxWUXPJkjXJt9diGG6jwJNBSPxk5_5Ai4yEw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 30 Oct 2024 at 12:01, Yushi Ogiwara
<btogiwarayuushi(at)oss(dot)nttdata(dot)com> wrote:
>
> I made a new patch (skip_xid_correctly.diff) that incorporates the
> points we discussed:
>
> 1. Fix the issue that consume_xids consumes nxids+1 XIDs.
> 2. Update lastxid when calling GetTopFullTransactionId() to support
> nxids==1 case.
> 3. Forbid consume_xids when nxids==0.
> 4. Add comments explaining the return values of consume_xids and
> consume_xids_until, and the rationale for incrementing consumed++ when
> GetTopFullTransactionId() is called.
>
> Also, I made another patch (support_blksz_32k.diff) that supports the
> block size == 32K case.
>
> Best,
> Yushi Ogiwara
>
Hi!
There is review comments that need to be addressed in [1]
Patch status now is waiting on author
--
Best regards,
Kirill Reshke
| From | Date | Subject | |
|---|---|---|---|
| Next Message | a.mitrokhin | 2024-12-03 09:38:39 | Building an extension in a separate directory from the source files. |
| Previous Message | Kirill Reshke | 2024-12-03 09:24:41 | Re: Sequence Access Methods, round two |