| From: | Yushi Ogiwara <btogiwarayuushi(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix for consume_xids advancing XIDs incorrectly |
| Date: | 2024-10-30 07:00:52 |
| Message-ID: | 1ea3663012d0cafb5639290eb19e3f71@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I made a new patch (skip_xid_correctly.diff) that incorporates the
points we discussed:
1. Fix the issue that consume_xids consumes nxids+1 XIDs.
2. Update lastxid when calling GetTopFullTransactionId() to support
nxids==1 case.
3. Forbid consume_xids when nxids==0.
4. Add comments explaining the return values of consume_xids and
consume_xids_until, and the rationale for incrementing consumed++ when
GetTopFullTransactionId() is called.
Also, I made another patch (support_blksz_32k.diff) that supports the
block size == 32K case.
Best,
Yushi Ogiwara
| Attachment | Content-Type | Size |
|---|---|---|
| skip_xid_correctly.diff | text/x-diff | 1.6 KB |
| support_blksz_32k.diff | text/x-diff | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hunaid Sohail | 2024-10-30 07:07:51 | Re: [PATCH] Add roman support for to_number function |
| Previous Message | Tatsuo Ishii | 2024-10-30 06:49:19 | Re: protocol-level wait-for-LSN |