From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
---|---|
To: | jian he <jian(dot)universality(at)gmail(dot)com> |
Cc: | vignesh C <vignesh21(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: speedup COPY TO for partitioned table. |
Date: | 2025-04-07 16:54:13 |
Message-ID: | CALdSSPiZZPxXsfy-HKDqipP0CBq8Qhd8-inUBpjCX_00yh0z-Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, 4 Apr 2025, 15:17 Kirill Reshke, <reshkekirill(at)gmail(dot)com> wrote:
> Hi!
>
> First of all, a commit message does not need to contain SQL examples
> of what it does. We should provide human-readable explanations and
> that's it.
>
> Next, about changes to src/test/regress/sql/copy2.sql. I find the sql
> you used to test really unintuitive. How about CREATE TABLE ...
> PARTITION OF syntax? It is also one command instead of two (create +
> alter). It is also hard to say what partition structure is, because
> column names on different partition levels are the same, just order is
> switched. Let's change it to something more intuitive too?
>
>
>
> --
> Best regards,
> Kirill Reshke
>
Maybe we can tab-complete here if prefix matches pg_% ? Does that makes
good use case?
>
From | Date | Subject | |
---|---|---|---|
Next Message | Ashutosh Bapat | 2025-04-07 16:54:33 | Re: [PoC] Reducing planning time when tables have many partitions |
Previous Message | Andres Freund | 2025-04-07 16:52:57 | Re: [PoC] Federated Authn/z with OAUTHBEARER |