Re: Using read_stream in index vacuum

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
Cc: Rahila Syed <rahilasyed90(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: Using read_stream in index vacuum
Date: 2024-11-28 15:29:45
Message-ID: CALdSSPhHCx-0a96H7-PTuYSY1YcOV+LBLpKzGgupDuQjaRt2sA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 18 Nov 2024 at 16:34, Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>
>
>
> > On 2 Nov 2024, at 02:36, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> >
> > I noticed CI failure for this patch. This does not look like a flap.
>
> Seems like vacuum did not start index cleanup. I’ve added "index_cleanup on".
> Thanks!
>
>
> Best regards, Andrey Borodin.

Hi!

0001 Looks mature. Some comments:
1)
>+# This ensures autovacuum do not run
>+$node->append_conf('postgresql.conf', 'autovacuum = off');
The other option is to set `autovacuum = off `in relation DDL. I'm not
sure which option is better.

2) Are these used?
my $psql_err = '';
my $psql_out = '';

Should we add tap testing to 0002 & 0003 like 0001 already has?

--
Best regards,
Kirill Reshke

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2024-11-28 15:33:04 Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row
Previous Message Kirill Reshke 2024-11-28 15:18:21 Re: Useless field ispartitioned in CreateStmtContext