Re: Using read_stream in index vacuum

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
Cc: Rahila Syed <rahilasyed90(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: Using read_stream in index vacuum
Date: 2024-11-01 21:36:51
Message-ID: CALdSSPh82+TVme+R2paO_RAeU-zqZWFmjneQYoZLjDwaCbrfXw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

On Fri, 25 Oct 2024 at 17:01, Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>
>
>
> > On 25 Oct 2024, at 00:55, Rahila Syed <rahilasyed90(at)gmail(dot)com> wrote:
> >
> > While writing this email, I realized I evicted buffers for the table
> > and not the index. I will perform the test again. However,
> > I would like to know your opinion on whether this looks like
> > a valid test.
>
> Well, yes, kind of, you need drop caches from index. And, perhaps, you can have more indexes. You also can disable autovaccum and just restart postgres instead of iterating through buffer caches.
>
> I've asked Thomas about performance implications and he told me that converting stuff to streamlined API is not expected to have better performance. It's needed to have decent perfromance when DIRECT_IO will be involved.
>
> Thanks!
>
>
> Best regards, Andrey Borodin.
>

I noticed CI failure for this patch. This does not look like a flap.

[0] https://cirrus-ci.com/task/4527545259917312
[1] https://api.cirrus-ci.com/v1/artifact/task/4527545259917312/log/src/test/modules/test_misc/tmp_check/log/regress_log_007_vacuum_btree

--
Best regards,
Kirill Reshke

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-11-01 21:38:41 Re: Count and log pages set all-frozen by vacuum
Previous Message Masahiko Sawada 2024-11-01 21:28:35 Re: New "raw" COPY format