set_rel_pathlist function unnecessary params.

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: set_rel_pathlist function unnecessary params.
Date: 2024-09-30 19:38:56
Message-ID: CALdSSPh+0z5=7aVMTpAr-qhOdTTT4rLrr2YsRiBO6uznJD1Kew@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I happened to notice that `set_rel_pathlist` params, RelOptInfo *rel
and RangeTblEntry *rte are
unnecessary, because upon all usages,
`rte=root->simple_rte_array[rti]` and
`rel=root->simple_rel_array[rti]` holds. What's the point of providing
the same information 3 times? Is it kept like that for extension
backward compatibility.

So, I propose to refactor this a little bit.

Am I missing something?

--
Best regards,
Kirill Reshke

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-09-30 19:56:22 Re: set_rel_pathlist function unnecessary params.
Previous Message Noah Misch 2024-09-30 19:33:50 Re: Inval reliability, especially for inplace updates