Re: Amcheck verification of GiST and GIN

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
Cc: Alexander Lakhin <exclusion(at)gmail(dot)com>, Andrey Borodin <amborodin86(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Jose Arthur Benetasso Villanova <jose(dot)arthur(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(at)vondra(dot)me>
Subject: Re: Amcheck verification of GiST and GIN
Date: 2024-12-16 18:17:10
Message-ID: CALdSSPg++w6AqzDukm23djkiBfimhGbgn3zz=8VHVV85MDV8Hw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all.

I was reviewing nearby thread about parallel index creation for GIN,
and spotted this test [0] :

create table gin_t (a int[]);
insert into gin_t select * from rand_array(30000000, 0, 100, 0, 50);
create index on gin_t using gin(a);

v34 fails on this. The reason is we should never check the high key on
the rightmost page in the entry GIN tree explicitly, as this is not
actually stored.

PFA little v35 fix for this. I will update this thread with a full v35
patch set shortly.

[0] https://www.postgresql.org/message-id/87a5gyqnl5.fsf%40163.com

--
Best regards,
Kirill Reshke

Attachment Content-Type Size
v35-0001-Fix-for-gin_index_check.patch application/octet-stream 4.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2024-12-16 18:19:17 Re: Regression tests fail on OpenBSD due to low semmns value
Previous Message Nathan Bossart 2024-12-16 18:10:55 Re: Pg18 Recursive Crash