| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Anton Voloshin <a(dot)voloshin(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Re: duplicate function declaration in multirangetypes_selfuncs.c |
| Date: | 2023-04-21 10:45:16 |
| Message-ID: | CALT9ZEH_A7KLLmzxFdQCgLSbVeAWOAnsPHzAwW-0hxO5qQ2TsA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
On Fri, 21 Apr 2023 at 14:34, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 21 Apr 2023, at 12:32, Anton Voloshin <a(dot)voloshin(at)postgrespro(dot)ru> wrote:
>
> > we have a duplicate line, declaration of default_multirange_selectivity() in
> > src/backend/utils/adt/multirangetypes_selfuncs.c:
> >
> > static double default_multirange_selectivity(Oid operator);
> > static double default_multirange_selectivity(Oid operator);
>
> Nice catch.
>
> > No harm from this duplication, still, I suggest to clean it up for tidiness' sake.
>
> +1
>
The patch is attached. Anyone to commit?
Pavel Borisov
Supabase
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-double-declaration-of-default_multirange_sele.patch | application/octet-stream | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2023-04-21 10:55:44 | Re: Reorder connection markers in libpq TAP tests |
| Previous Message | Daniel Gustafsson | 2023-04-21 10:34:11 | Re: duplicate function declaration in multirangetypes_selfuncs.c |