From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | Anton Voloshin <a(dot)voloshin(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
Subject: | Re: duplicate function declaration in multirangetypes_selfuncs.c |
Date: | 2023-04-21 11:21:24 |
Message-ID: | CALT9ZEHDdPgg6+jmrha3w5KMMXK7p09kgm_V5vG9_s_wDaFBvQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi!
On Fri, 21 Apr 2023 at 15:14, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 21 Apr 2023, at 12:58, Anton Voloshin <a(dot)voloshin(at)postgrespro(dot)ru> wrote:
> >
> > On 21/04/2023 13:45, Pavel Borisov wrote:
> >> The patch is attached. Anyone to commit?
> >
> > Speaking of duplicates, I just found another one:
> > > break;
> > > break;
> > in src/interfaces/ecpg/preproc/variable.c
> > (in all stable branches).
>
> Indeed, coming in via 086cf1458 it's over a decade old.
>
> > Additional patch attached. Or both could go in the same commit, it's up to committer.
>
> I'll take care of these in a bit (unless someone finds more, or objects)
> backpatching them to their respective origins branches.
>
> --
> Daniel Gustafsson
Technically patches 0001 and 0002 in the thread above don't form
patchset i.e. 0002 will not apply over 0001. Fixed this in v2.
(They could be merged into one but as they fix completely unrelated
things, I think a better way to commit them separately.)
Pavel.
Attachment | Content-Type | Size |
---|---|---|
v2-0002-Remove-duplicate-break-in-find_struct_member-s-sw.patch | application/octet-stream | 953 bytes |
v2-0001-Remove-double-declaration-of-default_multirange_s.patch | application/octet-stream | 1.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Ajit Awekar | 2023-04-21 11:25:20 | Re: Memory leak in CachememoryContext |
Previous Message | Ranier Vilela | 2023-04-21 11:16:01 | Re: Improve list manipulation in several places |