From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
---|---|
To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Fortify float4 and float8 regression tests by ordering test results |
Date: | 2025-04-22 16:52:15 |
Message-ID: | CALT9ZEGcRK3nCvg01CoK74Tk2Ua1kHBC52K0nV2On_ELyncQhg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi!
On Tue, 22 Apr 2025 at 20:22, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
>
> On Tue, Apr 22, 2025 at 7:20 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Alexander Korotkov <aekorotkov(at)gmail(dot)com> writes:
> > > I'd like to add that float4.out not only assumes that insert-ordering is
> > > preserved (this could be more-or-less portable between table AMs). It also
> > > assumes the way UPDATE moves updated rows. That seems quite
> > > heap-specific. You can see in the following fragment, updated rows jump to
> > > the bottom.
> >
> > I'd be willing to consider a policy that we don't want to depend on
> > exactly where UPDATE moves rows to. The proposed patch is not that,
> > however.
>
> OK, that makes sense for me.
Thanks for this input!
This was my first intention to fix only the test that was affected by
UPDATE-order specifics, broke when runnung on an extension AM.
Maybe I was too liberal and added ORDER BY's more than needed.
I definitely agree to the proposal.
Please find attached v2 that fixes only UPDATE-specific part of
float4/float8 test.
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Fortify-float4-and-float8-regression-tests-agains.patch | application/octet-stream | 2.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Laurenz Albe | 2025-04-22 16:55:49 | Re: Cygwin support |
Previous Message | Tom Lane | 2025-04-22 16:41:04 | Re: What's our minimum supported Python version? |