From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Refine comments on usage WL_POSTMASTER_DEATH vs WL_EXIT_ON_PM_DEATH |
Date: | 2024-10-23 17:29:39 |
Message-ID: | CALT9ZEF_GQRr2DCNg2Ax0d+oN9UtLe93Kcer93k-SySVh8Sp6w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi, Heikki!
On Wed, 23 Oct 2024 at 21:00, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> On 23/10/2024 12:18, Pavel Borisov wrote:
> > Hi, Hackers!
> >
> > Current comments on the usage of WL_POSTMASTER_DEATH state that it
> > should be used for scenarios of finishing other than immediately i.e.
> > returning values and waiting for postmaster dies.
> > In fact, in parts of the code, it's currently used to immediately exit
> > or throw FATAL (in the walsender and in libpq).
> >
> > So I propose change the comments on WL_POSTMASTER_DEATH stating that it
> > could be used for both cases: for processing and setting return values
> > if that's needed, and for immediate exit otherwise.
>
> I see what you mean, but I don't think the proposed patch is making it
> better. With WL_POSTMASTER_DEATH, the WaitLatch call returns if the
> postmaster dies. What the caller does then is the caller's business.
> That's different from WL_EXIT_ON_PM_DEATH in that with
> WL_EXIT_ON_PM_DEATH, WaitLatch itself will do the exit(), not the caller.
>
That was exactly my point. Actually the caller should not wait, it could do
whatever it wants contrary to the existing comments:
> WL_POSTMASTER_DEATH: Wait for postmaster to die
I don't insist on this patch, but existing comments on this look somewhat
misleading.
Regards,
Pavel Borisov
From | Date | Subject | |
---|---|---|---|
Next Message | Andrey M. Borodin | 2024-10-23 17:57:28 | Re: Using read_stream in index vacuum |
Previous Message | Tom Lane | 2024-10-23 17:20:27 | Re: Inconsistent use of relpages = -1 |