| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl |
| Date: | 2022-07-06 13:22:14 |
| Message-ID: | CALT9ZEF-EwaQ8R_7Eay2Vj7500UnHzJBRy7_iGDEEqY_cchqoA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 6, 2022 at 5:05 PM Maxim Orlov <orlovmg(at)gmail(dot)com> wrote:
> Hi!
>
> This is an obvious change, I totally for it. Hope it will be commited soon.
>
I'm sorry for some nitpicking about changes in the comments:
- The number of WAL segments advanced hasn't changed from 5 to 1, it just
advances as 1+4 as previously. So the original comment is right. I reverted
this in v2.
- wal_segment_size is in bytes so comment "(wal_segment_size * n) MB" is
incorrect. I corrected this to bytes.
PFA v2 of a patch (only comments changed/reverted to original).
Overall I completely agree with Maxim: the patch is good and simple enough
to be RfC.
--
Best regards,
Pavel Borisov
Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-unnecessary-includes-and-comments-in-019_repl.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maxim Orlov | 2022-07-06 13:26:38 | Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl |
| Previous Message | Andres Freund | 2022-07-06 13:21:26 | Re: [RFC] building postgres with meson -v9 |