| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Fortify float4 and float8 regression tests by ordering test results |
| Date: | 2025-04-22 13:31:57 |
| Message-ID: | CALT9ZEExHAnBoBVQzQuWPMKUbapF5-FBO3fdeYG3s2tuWQz1NQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, hackers!
I noticed that SELECT results in float4 and float8 tests lack ORDER BY
clauses. This makes test results depend on the current heap/MVCC
implementation.
If I try to run the float8 test on a table created with a different
access method provided by an extension, I'm getting results ordered
differently.
It's not a big problem, but propose a simple fix for the tests. It
just adds ORDER BY 1 to all relevant float4 and floa8 queries. I don't
have a strong opinion about backpatching this, but as the patch
changes only regression tests, it's maybe also worth backpatching.
Regards,
Pavel Borisov,
Supabase.
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fortify-float4-and-float8-tests-by-ordering-test-.patch | application/octet-stream | 19.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2025-04-22 14:13:18 | Re: Fortify float4 and float8 regression tests by ordering test results |
| Previous Message | Alexey Makhmutov | 2025-04-22 12:40:53 | Re: High CPU consumption in cascade replication with large number of walsenders and ConditionVariable broadcast issues |