From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
---|---|
To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: range_agg |
Date: | 2020-12-16 23:37:50 |
Message-ID: | CALNJ-vTwZccJE-aXH3dnL8n6kZtR1+4Jo5jWBwzWt+0thL1XRA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Letting user manually name the multirange (after a few automatic attempts)
seems reasonable.
Cheers
On Wed, Dec 16, 2020 at 3:34 PM Alexander Korotkov <aekorotkov(at)gmail(dot)com>
wrote:
> On Thu, Dec 17, 2020 at 1:03 AM Alexander Korotkov <aekorotkov(at)gmail(dot)com>
> wrote:
> > On Thu, Dec 17, 2020 at 12:54 AM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> > > + * The idea is to prepend underscores as needed until we make a
> name that
> > > + * doesn't collide with anything ...
> > >
> > > I wonder if other characters (e.g. [a-z0-9]) can be used so that name
> without collision can be found without calling truncate_identifier().
> >
> > Probably. But multiranges just shares naming logic already existing
> > in arrays. If we're going to change this, I think we should change
> > this for arrays too. And this change shouldn't be part of multirange
> > patch.
>
> I gave this another thought. Now we have facility to name multirange
> types manually. I think we should give up with underscore naming
> completely. If both replacing "range" with "mutlirange" in the
> typename and appending "_multirange" to the type name failed (very
> unlikely), then let user manually name the multirange. Any thoughts?
>
> ------
> Regards,
> Alexander Korotkov
>
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2020-12-16 23:41:17 | Re: range_agg |
Previous Message | Alexander Korotkov | 2020-12-16 23:34:39 | Re: range_agg |