| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: freeing LDAPMessage in CheckLDAPAuth |
| Date: | 2022-09-05 09:50:09 |
| Message-ID: | CALNJ-vTA3vayCXWNWy8vQ5A9HgVEC7ZiaGfMsaH5wJ3gRKqvnw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Sep 4, 2022 at 10:37 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Sun, Sep 04, 2022 at 06:52:37AM -0700, Zhihong Yu wrote:
> > Please take a look at patch v3.
>
> Fine as far as it goes. I would have put the initialization of
> search_message closer to ldap_search_s() for consistency with libpq.
> That's what we do with ldap_search_st().
> --
> Michael
>
Hi,
Here is patch v4.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-ldap-msg-free.patch | application/octet-stream | 712 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2022-09-05 09:56:33 | Re: more descriptive message for process termination due to max_slot_wal_keep_size |
| Previous Message | Amit Kapila | 2022-09-05 09:40:41 | Re: Handle infinite recursion in logical replication setup |