| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)fujitsu(dot)com>, Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Amit Langote <amitlangote09(at)gmail(dot)com>, tanghy(dot)fnst(at)fujitsu(dot)com, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, Michael Paquier <michael(at)paquier(dot)xyz>, Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, houzj(dot)fnst(at)fujitsu(dot)com |
| Subject: | Re: [POC] Fast COPY FROM command for the table with foreign partitions |
| Date: | 2021-04-09 01:42:40 |
| Message-ID: | CALNJ-vSvDfpuoZfOgkP+=6eAwn6VPFAARhPT_aW6HAhK63NC9Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 8, 2021 at 5:49 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> I rebased this patch to resolve a trivial 1 line conflict from c5b7ba4e6.
>
> --
> Justin
>
Hi,
In src/backend/commands/copyfrom.c :
+ if (resultRelInfo->ri_RelationDesc->rd_rel->relkind ==
RELKIND_FOREIGN_TABLE)
There are a few steps of indirection. Adding assertion before the if
statement on resultRelInfo->ri_RelationDesc, etc would help catch potential
invalid pointer.
+CopyToStart(CopyToState cstate)
...
+CopyToFinish(CopyToState cstate)
Since 'copy to' is the action, it would be easier to read the method names
if they're called StartCopyTo, FinishCopyTo, respectively.
That way, the method names would be consistent with existing ones, such as:
extern uint64 DoCopyTo(CopyToState cstate);
+ * If a partition's root parent isn't allowed to use it, neither is the
In the above sentence, 'it' refers to multi insert. It would be more
readable to explicitly mention 'multi insert' instead of 'it'
Cheers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-04-09 01:47:01 | Re: TRUNCATE on foreign table |
| Previous Message | Peter Smith | 2021-04-09 01:39:25 | Re: [HACKERS] logical decoding of two-phase transactions |