| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Denis Hirn <denis(dot)hirn(at)uni-tuebingen(dot)de> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pantelis Theodosiou <ypercube(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Allow multiple recursive self-references |
| Date: | 2021-08-17 15:12:21 |
| Message-ID: | CALNJ-vSXdj-gvkpTdSQw8EMM-Nax7ibJ8HzC_SDbYhk5HENHyg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 17, 2021 at 5:58 AM Denis Hirn <denis(dot)hirn(at)uni-tuebingen(dot)de>
wrote:
> > The tests fail when you build with assertions enabled (configure
> --enable-cassert).
>
> Thank you for pointing that out. The new version of this patch fixes that.
> The tests are working properly now. All style related issues are fixed as
> well.
>
> Best wishes,
> -- Denis
>
>
> Hi,
+ selfrefcountL = cstate->selfrefcount;
+ cstate->selfrefcount = selfrefcount;
Maybe the variable selfrefcountL can be renamed slightly (e.g.
curr_selfrefcount) so that the code is easier to read.
Cheers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2021-08-17 15:26:29 | Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode |
| Previous Message | Zhihong Yu | 2021-08-17 14:47:40 | Re: Allow parallel DISTINCT |