From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
---|---|
To: | aekorotkov(at)gmail(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | range_agg |
Date: | 2020-12-16 21:54:45 |
Message-ID: | CALNJ-vSUpQ_Y=jXvTxt1VYFztaBSsWVXeF1y6gTYQ4bOiWDLgQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
w.r.t. patch v27.
+ * The idea is to prepend underscores as needed until we make a name
that
+ * doesn't collide with anything ...
I wonder if other characters (e.g. [a-z0-9]) can be used so that name
without collision can be found without calling truncate_identifier().
+ else if (strcmp(defel->defname, "multirange_type_name") == 0)
+ {
+ if (multirangeTypeName != NULL)
+ ereport(ERROR,
+ (errcode(ERRCODE_SYNTAX_ERROR),
+ errmsg("conflicting or redundant options")));
Maybe make the error message a bit different from occurrences of similar
error message (such as including multirangeTypeName) ?
Thanks
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2020-12-16 22:03:38 | Re: range_agg |
Previous Message | Stephen Frost | 2020-12-16 21:32:00 | Re: Proposed patch for key managment |