Freeing sortgroupatts in use_physical_tlist

From: Zhihong Yu <zyu(at)yugabyte(dot)com>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Freeing sortgroupatts in use_physical_tlist
Date: 2022-07-16 02:49:23
Message-ID: CALNJ-vSAMhMpkRY=rDW2MhC2FJwgwaAnnCq_6-bqif5OX=5RBg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
I was looking at the code in use_physical_tlist().

In the code block checking CP_LABEL_TLIST, I noticed that
the Bitmapset sortgroupatts is not freed before returning from the method.

Looking at create_foreignscan_plan() (in the same file):

bms_free(attrs_used);

It seems the intermediate Bitmapset is freed before returning.

I would appreciate review comments for the proposed patch.

Thanks

Attachment Content-Type Size
free-sort-group-atts.patch application/octet-stream 686 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-07-16 02:59:00 Re: Commitfest Update
Previous Message Justin Pryzby 2022-07-16 02:37:14 Re: Commitfest Update