| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: simplifying foreign key/RI checks |
| Date: | 2022-03-14 09:32:25 |
| Message-ID: | CALNJ-vRooFqxeXABu8hDSgrC4pRtmXNP6SJqeOO+25y_ByaRYg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 14, 2022 at 1:33 AM Amit Langote <amitlangote09(at)gmail(dot)com>
wrote:
> On Tue, Jan 18, 2022 at 3:30 PM Amit Langote <amitlangote09(at)gmail(dot)com>
> wrote:
> > v13 is attached.
>
> I noticed that the recent 641f3dffcdf's changes to
> get_constraint_index() made it basically unusable for this patch's
> purposes.
>
> Reading in the thread that led to 641f3dffcdf why
> get_constraint_index() was changed the way it was, I invented in the
> attached updated patch a get_fkey_constraint_index() that is local to
> ri_triggers.c for use by the new ri_ReferencedKeyExists(), replacing
> get_constraint_index() that no longer gives it the index it's looking
> for.
>
> --
> Amit Langote
> EDB: http://www.enterprisedb.com
Hi,
+ partkey_isnull[j] = (key_nulls[k] == 'n' ? true :
false);
The above can be shortened as:
partkey_isnull[j] = key_nulls[k] == 'n';
+ * May neeed to cast each of the individual values of the foreign
key
neeed -> need
Cheers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nitin Jadhav | 2022-03-14 09:46:50 | Re: Report checkpoint progress with pg_stat_progress_checkpoint (was: Report checkpoint progress in server logs) |
| Previous Message | Daniel Gustafsson | 2022-03-14 08:50:25 | Re: On login trigger: take three |