Re: [PATCH] Support pg_ident mapping for LDAP

From: Zhihong Yu <zyu(at)yugabyte(dot)com>
To: Jacob Champion <pchampion(at)vmware(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Support pg_ident mapping for LDAP
Date: 2021-09-01 19:59:32
Message-ID: CALNJ-vRQpSkineEB_YB9m64GBMLinF=j6zuUHOhpfgMFjWKMWw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 1, 2021 at 11:43 AM Jacob Champion <pchampion(at)vmware(dot)com> wrote:

> On Wed, 2021-09-01 at 15:42 +0000, Jacob Champion wrote:
> > The cfbot found a failure in postgres_fdw, which I completely neglected
> > in my design. I think the desired functionality should be to allow the
> > ldapuser connection option during CREATE USER MAPPING but not CREATE
> > SERVER.
>
> Fixed in v2, attached.
>
> --Jacob
>
Hi,

+ if (strcmp(val, "1") == 0)
+ hbaline->ldap_map_dn = true;
+ else
+ hbaline->ldap_map_dn = false;

The above can be shortened as:

hbaline->ldap_map_dn = strcmp(val, "1") == 0;

Cheers

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2021-09-01 20:00:58 Re: Postgres Win32 build broken?
Previous Message Tomas Vondra 2021-09-01 19:56:20 Re: PoC/WIP: Extended statistics on expressions