| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com>, Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Subject: | Re: Add proper planner support for ORDER BY / DISTINCT aggregates |
| Date: | 2022-08-02 19:38:22 |
| Message-ID: | CALNJ-vRMSMf7MPZ917pT8gGdtE95rrouCXReuNjOuoQYMOjdgQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 2, 2022 at 11:02 AM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
>
>> Hi, David:
>
> I was looking at the final patch and noticed that setno field
> in agg_presorted_distinctcheck struct is never used.
>
> Looks like it was copied from neighboring struct.
>
> Can you take a look at the patch ?
>
> Thanks
>
>>
>
> Looks like setoff field is not used either.
Cheers
| Attachment | Content-Type | Size |
|---|---|---|
| drop-setno-setoff-from-agg_presorted_distinctcheck.patch | application/octet-stream | 420 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-08-02 19:39:59 | Re: pg15b2: large objects lost on upgrade |
| Previous Message | Tom Lane | 2022-08-02 19:32:05 | Re: pg15b2: large objects lost on upgrade |