| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, Maksim Milyutin <milyutinma(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Add client connection check during the execution of the query |
| Date: | 2021-10-08 03:57:39 |
| Message-ID: | CALNJ-vQbNVH=-kEr+wB94LYinCZf3XNcOTc+vkm=sF9YD5G8zg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 7, 2021 at 8:43 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Sat, Jun 12, 2021 at 8:31 PM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> > +#ifdef POLLRDHUP
> > + if ((cur_event->events & WL_SOCKET_CLOSED) &&
> > + (cur_pollfd->revents & (POLLRDHUP | errflags)))
> >
> > It seems the last condition above should be written as:
> >
> > ((cur_pollfd->revents & POLLRDHUP) | (cur_pollfd->revents & errflags))
>
> Hi Zhihong,
>
> Why? Isn't (A & B) | (A & C) is the same as A & (B | C)?
>
Hi,
My former comment was about 4 months old.
The current way as expressed in the patch should be fine.
Cheers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2021-10-08 04:24:54 | Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. |
| Previous Message | Amit Kapila | 2021-10-08 03:47:14 | Re: [BUG] Unexpected action when publishing partition tables |