| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | James Coleman <jtc331(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Peter Geoghegan <pg(at)bowt(dot)ie>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays |
| Date: | 2021-05-08 08:21:44 |
| Message-ID: | CALNJ-vQKp1gH9xr_FRTGfNERaAVcxMh+23u8_M7zKpskevbC5w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 7, 2021 at 9:50 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Sat, 8 May 2021 at 14:04, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > I'm not opposed to adding some new field if that's what it takes. I'd
> > imagine the new field will be something like negfuncid which will be
> > InvalidOid unless the hash function is set and useOr == false
>
> Just while this is still swapped into main memory, I've attached a
> patch that adds a new field to ScalarArrayOpExpr rather than
> repurposing the existing field.
>
> David
>
Hi,
+ if (!OidIsValid(saop->negfuncid))
+ record_plan_function_dependency(root, saop->hashfuncid);
Is there a typo in the second line ? (root, saop->negfuncid)
Cheers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2021-05-08 08:29:30 | Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays |
| Previous Message | Nitin Jadhav | 2021-05-08 08:19:58 | Re: Query regarding RANGE Partitioning |