| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Date: | 2025-02-10 12:42:12 |
| Message-ID: | CALDaNm3d3MFEgZFLHTUcYiTHH2U0NgYGjs0fgSMmCVftr+aosQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 10 Feb 2025 at 17:33, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
>
> Here are the v73 patches incorporating the comments above and the
> subsequent comments from [1].
> - patch 002 is rebased on 001 with no new changes.
Few comments:
1) For some reason SlotInvalidationCauses was with PGDLLIMPORT, this
is removed now. This is required if it needs to be accessible by
loaded modules. Is there any impact or is it ok?
-extern PGDLLIMPORT const char *const SlotInvalidationCauses[];
+typedef struct SlotInvalidationCauseMap
+{
+ int cause;
+ const char *cause_name;
+} SlotInvalidationCauseMap;
2) The new structure should be added to typedefs.list:
+typedef struct SlotInvalidationCauseMap
+{
+ int cause;
+ const char *cause_name;
+} SlotInvalidationCauseMap;
3) After adding you can run pgindent on slot.h to indent the following code:
+typedef struct SlotInvalidationCauseMap
+{
+ int cause;
+ const char *cause_name;
+} SlotInvalidationCauseMap;
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | torikoshia | 2025-02-10 13:23:06 | Re: RFC: Allow EXPLAIN to Output Page Fault Information |
| Previous Message | Melih Mutlu | 2025-02-10 12:41:14 | Re: Separate memory contexts for relcache and catcache |