| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, euler(at)eulerto(dot)com |
| Subject: | Re: Pgoutput not capturing the generated columns |
| Date: | 2024-11-03 13:27:58 |
| Message-ID: | CALDaNm3R_VRDpUfP8yu4sjbh=FK2WYWbqtbQi7sWuTxQA907bQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 31 Oct 2024 at 16:44, Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
>
>
> On Thu, Oct 31, 2024 at 9:55 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>>
>> I ran some tests and verified that the patch works with previous versions of PG12 and PG17
>> 1. Verified with publications with generated columns and without generated columns on patched code and subscriptions on PG12 and PG17
>> Observations:
>> a. If publication is created with publish_generated_columns=true or with generated columns mentioned explicitly, then tablesync will not copy generated columns but post tablesync the generated columns are replicated
>> b. Column list override (publish_generated_columns=false) behaviour
>>
>> These seem expected.
>>
>
> Currently the documentation does not talk about this behaviour, I suggest this be added similar to how such a behaviour was documented when the original row-filter version was committed.
> Suggestion:
> "If a subscriber is a pre-18 version, the initial table synchronization won't publish generated columns even if they are defined in the publisher."
The updated patch has the changes for the same.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Update-Documentation-for-Generated-Columns-in-Log.patch | text/x-patch | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2024-11-03 15:22:26 | Re: Pgoutput not capturing the generated columns |
| Previous Message | feichanghong | 2024-11-03 11:56:43 | Re: Improve the efficiency of _bt_killitems. |