From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, David Pirotte <dpirotte(at)gmail(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br> |
Subject: | Re: subscriptioncheck failure |
Date: | 2021-05-13 12:11:43 |
Message-ID: | CALDaNm387e+SP9BxaLvboZQBE1rgQ0qgD-39H-jjjnRpme=wOg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, May 13, 2021 at 4:41 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, May 13, 2021 at 04:14:55PM +0530, vignesh C wrote:
> > +$node_publisher->wait_for_catchup('tap_sub');
> > +
> > # Ensure a transactional logical decoding message shows up on the slot
> > $node_subscriber->safe_psql('postgres', "ALTER SUBSCRIPTION tap_sub DISABLE");
> >
> > # wait for the replication connection to drop from the publisher
> > $node_publisher->poll_query_until('postgres',
> > - 'SELECT COUNT(*) FROM pg_catalog.pg_stat_replication', 0);
> > + "SELECT COUNT(*) FROM pg_catalog.pg_replication_slots WHERE slot_name = 'tap_sub' AND active='f'", 1);
>
> There are three places in this test where a slot is disabled, followed
> by a wait to make sure that the slot is gone. Perhaps it would be
> better to wrap that in a small-ish routine?
Yes that would be better, I will make the changes for this and post a patch.
Regards,
Vignesh
From | Date | Subject | |
---|---|---|---|
Next Message | Julien Rouhaud | 2021-05-13 12:28:24 | Re: Executor code - found an instance of a WHILE that should just be an IF |
Previous Message | Amit Langote | 2021-05-13 12:09:33 | Re: Inherited UPDATE/DELETE vs async execution |