Re: Typos and inconsistencies in code

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Typos and inconsistencies in code
Date: 2019-10-29 11:57:20
Message-ID: CALDaNm31kcK63A13VqzO_=LBQy-4Mc11sCyy8Z0OXnqKRgSDWw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 29, 2019 at 9:19 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> Few comments:
> 1.
> * The act of allocating pages to recycle may have invalidated the
> - * results of our previous btree reserch, so repeat it. (We could
> + * results of our previous btree search, so repeat it. (We could
> * recheck whether any of our split-avoidance strategies that were
>
Fixed
> I think the old comment meant "btree research" but you changed to "btree search"
>
> 2.
> /* copy&pasted from .../src/backend/utils/adt/datetime.c
> - * and changesd struct pg_tm to struct tm
> + * and changes struct pg_tm to struct tm
> */
> Seems like this comment meant "Changed struct pg_tm to struct tm"
Fixed
Thanks for the review.
I have attached the updated patch with the fixes.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
0001-Fixed-typos-in-the-code-v2.patch text/x-patch 15.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2019-10-29 14:11:13 Re: strpos behavior change around empty substring in PG12
Previous Message Vik Fearing 2019-10-29 11:55:46 Re: Join Correlation Name