| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2024-12-23 07:22:28 |
| Message-ID: | CALDaNm2o6X5tL5KiyYALYcgmnV_+d4kszxbJ6QdgAE6vaPNiLg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 19 Dec 2024 at 04:58, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Vignesh,
>
> Here are some review comments for the patch v20241211-0003.
>
> ~~~
>
> 4.
> +/*
> + * Common code to fetch the up-to-date sync state info into the static lists.
> + *
> + * Returns true if subscription has 1 or more tables, else false.
> + *
> + * Note: If this function started the transaction (indicated by the parameter)
> + * then it is the caller's responsibility to commit it.
> + */
> +bool
> +FetchRelationStates(bool *started_tx)
>
> Here is another place where the function name is "relations", but the
> function comment refers to "tables".
In this place the use of tables in comment is intentional, as the
return is based on subscription having any tables, and is not
applicable for sequence.
The rest of the comments are fixed and the changes for the same are
available at the v202412123 version patch shared at [1].
[1] - https://www.postgresql.org/message-id/CALDaNm0FqKMqOdm7tNoT5KgK1BAMeeVnOXrSJ2024TscAbf4Og%40mail.gmail.com
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniil Davydov | 2024-12-23 07:44:15 | Repeatable read transaction doesn't see dropped table |
| Previous Message | vignesh C | 2024-12-23 07:20:14 | Re: Logical Replication of sequences |