| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Tab completion for "ALTER TYPE typename SET" and rearranged "Alter TYPE typename RENAME" |
| Date: | 2022-08-14 14:26:00 |
| Message-ID: | CALDaNm2a7ptprv-Tw_n9S=guhPDAzhvSfGyBU0ya6_ERQubzkg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Aug 14, 2022 at 3:41 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sun, Aug 14, 2022 at 08:25:01AM +0530, vignesh C wrote:
> > Attached patch has the changes for the same. Thoughts?
> >
> > a) Add tab completion for "ALTER TYPE typename SET" was missing.
>
> Why not. I can also note that CREATE TYPE lists all the properties
> that can be set to a new type. We could bother adding these for ALTER
> TYPE, perhaps?
Modified the patch to list all the properties in case of "ALTER TYPE
typename SET (". I have included the properties in alphabetical order
as I notice that the ordering is in alphabetical order in few cases
ex: "ALTER SUBSCRIPTION <name> SET (". The attached v2 patch has the
changes for the same. Thoughts?
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Tab-completion-for-ALTER-TYPE-typename-SET-and-re.patch | application/octet-stream | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2022-08-14 16:16:53 | bogus assert in logicalmsg_desc |
| Previous Message | Devrim Gündüz | 2022-08-14 14:25:58 | Re: latest patches not updated in repos |