| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Enhanced error message to include hint messages for redundant options error |
| Date: | 2021-05-02 10:30:59 |
| Message-ID: | CALDaNm2WU+sDt5F-n+tzXnzfRmHkpHuViZ7_48wUqCWGHm_SGA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, May 2, 2021 at 4:27 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2021-May-01, Bharath Rupireddy wrote:
>
> > IMO, it's not good to change the function API just for showing up
> > parse_position (which is there for cosmetic reasons I feel) in an error
> > which actually has the option name clearly mentioned in the error message.
>
> Why not? We've done it before, I'm sure you can find examples in the
> git log. The function API is not that critical -- these functions are
> mostly only called from ProcessUtility and friends.
I feel it is better to include it wherever possible.
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2021-05-02 11:42:54 | Re: Enhanced error message to include hint messages for redundant options error |
| Previous Message | Joel Jacobson | 2021-05-02 05:46:39 | Re: Regex performance regression induced by match-all code |