Re: Make default subscription streaming option as Parallel

From: vignesh C <vignesh21(at)gmail(dot)com>
To: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Make default subscription streaming option as Parallel
Date: 2024-10-07 10:33:10
Message-ID: CALDaNm2RDVhF-6k=Kyg6nEUOJ26ShZ_SYo8fm_26Km1mPW7THw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 7 Oct 2024 at 12:26, Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Vignesh,
>
> > One key point to consider is that the lock on transaction objects will
> > be held for a longer duration when using streaming in parallel. This
> > occurs because the parallel apply worker initiates the transaction as
> > soon as streaming begins, maintaining the lock until the transaction
> > is fully completed. As a result, for long-running transactions, this
> > extended lock can hinder concurrent access that requires a lock.
>
> So, the current default is the most conservative and can run anywhere; your
> proposal is a bit optimistic, right?

Yes, that is correct.

> One comment for your patch;
> Shouldn't we add a streaming=off case for pg_dump test? You added lines but no one
> passes it.
>

Update existing pg_dump tests to cover the streaming options, the
attached patch has the changes for the same.

Regards,
Vignesh

Attachment Content-Type Size
v2-0001-Make-default-value-for-susbcription-streaming-opt.patch application/octet-stream 21.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shlok Kyal 2024-10-07 11:15:03 Re: long-standing data loss bug in initial sync of logical replication
Previous Message Daniel Gustafsson 2024-10-07 09:56:20 Re: Commit fest 2024-09