Re: [PATCH] Completed unaccent dictionary with many missing characters

On Mon, 16 Jan 2023 at 20:07, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Fri, 4 Nov 2022 at 04:59, Ian Lawrence Barwick <barwick(at)gmail(dot)com> wrote:
> >
> > 2022年7月13日(水) 19:13 Przemysław Sztoch <przemyslaw(at)sztoch(dot)pl>:
> > >
> > > Dear Michael P.,
> > >
> > > 3. The matter is not that simple. When I change priorities (ie Latin-ASCII.xml is less important than Unicode decomposition),
> > > then "U + 33D7" changes not to pH but to PH.
> > > In the end, I left it like it was before ...
> > >
> > > If you decide what to do with point 3, I will correct it and send new patches.
> > >
> > > What is your decision?
> > > Option 1: We leave x as in Latin-ASCII.xml and we also have full compatibility with previous PostgreSQL versions.
> > > If they fix Latin-ASCII.xml at Unicode, it will fix itself.
> > >
> > > Option 2: We choose a lower priority for entries in Latin-ASCII.xml
> > >
> > > I would choose option 1.
> > >
> > > P.S. I will be going on vacation and it would be nice to close this patch soon. TIA.
> >
> > Hi
> >
> > This entry was marked as "Needs review" in the CommitFest app but cfbot
> > reports the patch no longer applies.
> >
> > We've marked it as "Waiting on Author". As CommitFest 2022-11 is
> > currently underway, this would be an excellent time update the patch.
> >
> > Once you think the patchset is ready for review again, you (or any
> > interested party) can move the patch entry forward by visiting
> >
> > https://commitfest.postgresql.org/40/3631/
> >
> > and changing the status to "Needs review".
>
> I was not sure if you will be planning to post an updated version of
> patch as the patch has been awaiting your attention from last
> commitfest, please post an updated version for it soon or update the
> commitfest entry accordingly. As CommitFest 2023-01 is currently
> underway, this would be an excellent time to update the patch.

There has been no updates on this thread for some time, so this has
been switched as Returned with Feedback. Feel free to open it in the
next commitfest if you plan to continue on this.

Regards,
Vignesh