Re: Random pg_upgrade 004_subscription test failure on drongo

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Random pg_upgrade 004_subscription test failure on drongo
Date: 2025-03-17 10:19:23
Message-ID: CALDaNm2LzW9iQB1=Q5PhMUvhzvYFeGkJFO+3tD8+r6bKS3whoA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 13 Mar 2025 at 18:10, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>
> Hmm, this problem isn't limited to this one pg_upgrade test, right? It
> could happen with any pg_upgrade invocation. And perhaps in a running
> server too, if a relfilenumber is reused quickly.

Yes, it can happen with these scenarios.

> In dropdb() and DropTableSpace() we do this:
>
> WaitForProcSignalBarrier(EmitProcSignalBarrier(PROCSIGNAL_BARRIER_SMGRRELEASE));
>
> Should we do the same here? Not sure where exactly to put that; perhaps
> in mdcreate(), if the creation fails with STATUS_DELETE_PENDING.

I felt mdcreate would be a good place to fix this issue.

Regards,
Vignesh

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-03-17 10:19:30 Re: Add Pipelining support in psql
Previous Message vignesh C 2025-03-17 10:13:42 Fix couple of typos