| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Shinoda, Noriyoshi (SXD Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com> |
| Subject: | Re: Pgoutput not capturing the generated columns |
| Date: | 2025-01-21 08:34:06 |
| Message-ID: | CALDaNm2GUvr8fLk2nRa_0mo9A4eqyPDgHVCgYZMuH2YS_Gjmdg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 20 Jan 2025 at 08:59, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> IIUC, patch v53-0004 is primarily a bug fix for a docs omission of the
> master implementation.
>
> So,
>
> 1. IMO think this patch in its current form must come *before* the
> 0003 patch where you changed the PUBLICATION option from bool to enum.
>
> 2. Then the patch (currently called) 0003 needs to update this doc
> fragment to change the type from bool to char; it should also itemise
> the possible values 'n', 's' saying what those values mean.
These changes are done in the v54 version patch attached at [1].
Another thought was to remove this patch as it will get handled when
the "Change publish_generated_columns option to use enumChange
publish_generated_columns option to use enum" patch gets committed.
Also the comments form [2] and [3] are handled at [1].
[1] - https://www.postgresql.org/message-id/CALDaNm3zxQfJwYw7PwxtvYFAeCk6WkRt2iWu8HPWih8BubwU9g%40mail.gmail.com
[2] - https://www.postgresql.org/message-id/CAHut%2BPvuNx57RB%3DfUZv95q1Eb_01Lzv-%3DEnWDcDE%2BqFh7_yVag%40mail.gmail.com
[3] - https://www.postgresql.org/message-id/CAHut%2BPv9X9LjTJt0wU%2BySbZU-sXCO_bFmEGxinROkA48f8Ws%2Bw%40mail.gmail.com
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hunaid Sohail | 2025-01-21 08:35:47 | Re: [PATCH] Add roman support for to_number function |
| Previous Message | Richard Guo | 2025-01-21 08:33:29 | Re: Eager aggregation, take 3 |