| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2025-01-04 04:33:24 |
| Message-ID: | CALDaNm2EAFQ5E2ge05JCAqXzziqqD8AM2UUsWd8P1RbFw-GrKQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 3 Jan 2025 at 09:07, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Vignesh,
>
> Some minor review comments for the patch v20241230-0003.
>
> ======
> src/backend/replication/logical/syncutils.c
>
> 1.
> + * syncutils.c
> + * PostgreSQL logical replication: common synchronization code
> + *
> + * Copyright (c) 2024, PostgreSQL Global Development Group
>
> Happy New Year.
>
> s/2024/2025/
Modified
> ~~~
>
> 2.
> +/*
> + * Enum representing the overall state of subscription relations state.
> + *
> + * SYNC_RELATIONS_STATE_NEEDS_REBUILD indicates that the subscription relations
> + * state is no longer valid and the subscription relations should be rebuilt.
> + *
> + * SYNC_RELATIONS_STATE_REBUILD_STARTED indicates that the subscription
> + * relations state is being rebuilt.
> + *
> + * SYNC_RELATIONS_STATE_VALID indicates that subscription relation state is
> + * up-to-date and valid.
> + */
>
> 2a.
> That first sentence saying "overall state of [...] state" is a bit strange.
>
> Maybe it can be reworded something like:
> Enum for phases of the subscription relations state.
Modified
> ~
>
> 2b.
> /is no longer valid and/is no longer valid, and/
Modified
>
> 2c.
> /that subscription relation state is up-to-date/that the subscription
> relation state is up-to-date/
Modified
The changes for the same are available at the v20250204 version patch
attached at [1].
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Harris | 2025-01-04 04:34:37 | Re: FileFallocate misbehaving on XFS |
| Previous Message | vignesh C | 2025-01-04 04:31:07 | Re: Logical Replication of sequences |