Re: Include access method in listTables output

On Tue, Jun 30, 2020 at 2:53 PM Georgios <gkokolatos(at)protonmail(dot)com> wrote:
>
>
> As promised, I gladly ament upon your request. Also included a fix for
> a minor oversight in tests, they should now be stable. Finally in this
> version, I extended a bit the logic to only include the access method column
> if the relations displayed can have one, for example sequences.
>

Patch applies cleanly, make check & make check-world passes.
One comment:
+ if (pset.sversion >= 120000 && !pset.hide_tableam &&
+ (showTables || showViews || showMatViews ||
showIndexes))
+ appendPQExpBuffer(&buf,
+ ",\n
am.amname as \"%s\"",
+
gettext_noop("Access Method"));

I'm not sure if we should include showViews, I had seen that the
access method was not getting selected for view.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com