Re: Request for comment on setting binary format output per session

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Dave Cramer <davecramer(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Merlin Moncure <mmoncure(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Request for comment on setting binary format output per session
Date: 2024-02-01 15:35:15
Message-ID: CALDaNm1r7=MHH4OeYyh58PMZZn94dCLRoVov5sv-83HhecpioA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, 27 Jan 2024 at 07:45, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Mon, 31 Jul 2023 at 21:58, Dave Cramer <davecramer(at)gmail(dot)com> wrote:
> >
> >
> > Dave Cramer
> >
> >
> > On Mon, 10 Jul 2023 at 03:56, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> >>
> >> > On 25 Apr 2023, at 16:47, Dave Cramer <davecramer(at)gmail(dot)com> wrote:
> >>
> >> > Patch attached with comments removed
> >>
> >> This patch no longer applies, please submit a rebased version on top of HEAD.
> >
> >
> > Rebased see attached
>
> CFBot shows that the patch does not apply anymore as in [1]:
> === Applying patches on top of PostgreSQL commit ID
> fba2112b1569fd001a9e54dfdd73fd3cb8f16140 ===
> === applying patch ./0001-Created-protocol.h.patch
> patching file src/backend/access/common/printsimple.c
> Hunk #1 succeeded at 22 with fuzz 2 (offset 1 line).
> Hunk #2 FAILED at 33.
> Hunk #3 FAILED at 66.
> 2 out of 3 hunks FAILED -- saving rejects to file
> src/backend/access/common/printsimple.c.rej
> patching file src/backend/access/transam/parallel.c
> Hunk #1 succeeded at 34 (offset 1 line).
> Hunk #2 FAILED at 1128.
> Hunk #3 FAILED at 1138.
> Hunk #4 FAILED at 1184.
> Hunk #5 succeeded at 1205 (offset 4 lines).
> Hunk #6 FAILED at 1218.
> Hunk #7 FAILED at 1373.
> Hunk #8 FAILED at 1551.
> 6 out of 8 hunks FAILED -- saving rejects to file
> src/backend/access/transam/parallel.c.rej
>
> Please post an updated version for the same.
>
> [1] - http://cfbot.cputube.org/patch_46_3777.log

The patch which you submitted has been awaiting your attention for
quite some time now. As such, we have moved it to "Returned with
Feedback" and removed it from the reviewing queue. Depending on
timing, this may be reversible. Kindly address the feedback you have
received, and resubmit the patch to the next CommitFest.

Regards,
Vignesh

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2024-02-01 15:45:06 Re: Volatile write caches on macOS and Windows, redux
Previous Message Robert Haas 2024-02-01 15:27:56 Re: Possibility to disable `ALTER SYSTEM`