Re: Tab completion for ATTACH PARTITION

From: vignesh C <vignesh21(at)gmail(dot)com>
To: bt23nguyent <bt23nguyent(at)oss(dot)nttdata(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Tab completion for ATTACH PARTITION
Date: 2024-01-29 03:09:28
Message-ID: CALDaNm1q06beRVWR3V94Qk7WkBu86aA3TVNK5ZjLofVahbmqFQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 13 Sept 2023 at 06:57, bt23nguyent <bt23nguyent(at)oss(dot)nttdata(dot)com> wrote:
>
> Hi,
>
> Currently, the psql's tab completion feature does not support properly
> for ATTACH PARTITION. When <TAB> key is typed after "ALTER TABLE
> <table_name> ATTACH PARTITION ", all possible table names should be
> displayed, however, foreign table names are not displayed. So I created
> a patch that addresses this issue by ensuring that psql displays not
> only normal table names but also foreign table names in this case.
>
> Any kind of feedback is appreciated.

I have changed the status of the commitfest entry to RWF as Alvaro's
comments have not yet been addressed. Kindly post an updated version
by addressing the comments and add a new commitfest entry for the
same.

Regards,
Vignesh

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Junwang Zhao 2024-01-29 03:10:45 Re: Make COPY format extendable: Extract COPY TO format implementations
Previous Message Masahiko Sawada 2024-01-29 02:41:59 Re: Make COPY format extendable: Extract COPY TO format implementations