| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
| Date: | 2021-06-29 12:00:54 |
| Message-ID: | CALDaNm1k0o-Q+WAKNWUk9pW_Sv7=cW06xA5txhg0rtpk6g-6aA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 29, 2021 at 12:26 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Jun 23, 2021 at 4:10 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> >
>
> The first two patches look mostly good to me. I have combined them
> into one and made some minor changes. (a) Removed opt_two_phase and
> related code from repl_gram.y as that is not required for this version
> of the patch. (b) made some changes in docs. Kindly check the attached
> and let me know if you have any comments? I am planning to push this
> first patch in the series tomorrow unless you or others have any
> comments.
Thanks for the updated patch, patch applies neatly and tests passed.
If you are ok, One of the documentation changes could be slightly
changed while committing:
+ <para>
+ Enables two-phase decoding. This option should only be used with
+ <option>--create-slot</option>
+ </para>
to:
+ <para>
+ Enables two-phase decoding. This option should only be specified with
+ <option>--create-slot</option> option.
+ </para>
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-06-29 12:37:30 | Re: Use PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot() |
| Previous Message | Masahiko Sawada | 2021-06-29 11:41:34 | Use PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot() |