| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Corrected documentation of data type for the logical replication message formats. |
| Date: | 2021-05-10 13:51:52 |
| Message-ID: | CALDaNm1hcnPUG99H-+3gduZ8Wv9kG0WnnQ7P+ZXnDPGRt-PGTA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, May 9, 2021 at 6:44 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Sun, May 9, 2021 at 10:38 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > Hi,
> >
> > For some of the logical replication messages the data type documented
> > was not correct, especially for lsn and xid. For lsn actual datatype
> > used is uint64 but is documented as int64, similarly for xid, datatype
> > used is uint32 but documented as int32.
> > Attached is a patch which has the fix for the same.
> > Thoughts?
>
> If you want to do this then there are more - e.g. Flags should be
> Uint8 instead of Int8.
Thanks for the comments.
I have made this change in v2 patch posted at [1].
This also includes the fix to specify uint8(0) at appropriate places.
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ian Lawrence Barwick | 2021-05-10 13:53:03 | Re: PG 14 release notes, first draft |
| Previous Message | vignesh C | 2021-05-10 13:45:56 | Re: Corrected documentation of data type for the logical replication message formats. |