Re: Non-superuser subscription owners

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Non-superuser subscription owners
Date: 2023-04-21 06:59:50
Message-ID: CALDaNm1hbVs2rOErd_-pTgP4azY_kc8mhXN1dscFb-Kx1S1QJQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 21 Apr 2023 at 01:49, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Thu, Apr 20, 2023 at 1:08 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > Pushed. I noticed that we didn't display this new subscription option
> > 'password_required' in \dRs+:
> >
> > postgres=# \dRs+
> >
> > List of subscriptions
> > Name | Owner | Enabled | Publication | Binary | Streaming |
> > Two-phase commit | Disable on error | Origin | Run as Owner? |
> > Synchronous commit | Conninfo | Skip LSN
> >
> > Is that intentional? Sorry, if it was discussed previously because I
> > haven't followed this discussion in detail.
>
> No, I don't think that's intentional. I just didn't think about it.

Here is a patch to display Password required with \dRs+ command. Also
added one test to describe subscription when password_required is
false, as all the existing tests were there only for password_required
as true.

Regards,
Vignesh

Attachment Content-Type Size
0001-Display-password_required-option-for-dRs-command.patch text/x-patch 36.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikita Malakhov 2023-04-21 07:14:01 Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns
Previous Message John Naylor 2023-04-21 06:50:34 Re: optimize several list functions with SIMD intrinsics