| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Added missing tab completion for alter subscription set option |
| Date: | 2021-06-14 02:50:40 |
| Message-ID: | CALDaNm1ejNSP_fcHy9wDCZwY7OLGUTw_vWTTSZcXG5yk+qe1UA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 11, 2021 at 12:27 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sun, May 23, 2021 at 04:24:59PM +0530, vignesh C wrote:
> > /* Complete "CREATE SUBSCRIPTION <name> ... WITH ( <opt>" */
> > else if (HeadMatches("CREATE", "SUBSCRIPTION") && TailMatches("WITH", "("))
> > - COMPLETE_WITH("copy_data", "connect", "create_slot", "enabled",
> > - "slot_name", "synchronous_commit");
> > + COMPLETE_WITH("binary", "copy_data", "connect", "create_slot",
> > + "enabled", "slot_name", "streaming",
> > + "synchronous_commit");
>
> "copy_data" and "connect" need to be reversed. Applied.
Thanks for committing this.
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-06-14 03:04:23 | Re: Decoding speculative insert with toast leaks memory |
| Previous Message | Justin Pryzby | 2021-06-14 02:29:02 | Re: unnesting multirange data types |