Re: pgsql: Clean up role created in new subscription test.

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Clean up role created in new subscription test.
Date: 2024-01-18 00:57:47
Message-ID: CALDaNm1eHOMxq0GmZstftKW+W8xxRsG6Ww5u4ncEVq7ZD+NrVw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, 1 Dec 2023 at 18:23, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 1 Dec 2023, at 13:19, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> >
> > Isn't it simpler to use DROP OWNED BY in 0001?
>
> I suppose it is, I kind of like the explicit drops but we do use OWNED BY quite
> a lot in the regression tests so changed to that in the attached v5.

There are a lot of failures in CFBot at [1] with:
# test failed
----------------------------------- stderr -----------------------------------
# left over global object detected: regress_test_bypassrls
# 1 of 2 tests failed.

More details of the same are available at [2].
Do we need to clean up the objects leftover for the reported issues in the test?

[1] - https://cirrus-ci.com/task/6222185975513088
[2] - https://api.cirrus-ci.com/v1/artifact/task/6222185975513088/meson_log/build/meson-logs/testlog-running.txt

Regards,
Vignesh

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2024-01-18 01:13:25 pgsql: seg: Add test "security" in meson.build
Previous Message Alexander Korotkov 2024-01-17 21:23:36 pgsql: Remove the flaky check in event_trigger_login regression test

Browse pgsql-hackers by date

  From Date Subject
Next Message Sravan Kumar 2024-01-18 01:09:15 Re: Add system identifier to backup manifest
Previous Message Masahiko Sawada 2024-01-18 00:56:39 Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)