| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Nikolay Samokhvalov <nik(at)postgres(dot)ai>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump, pg_dumpall, pg_restore: Add --no-policies option |
| Date: | 2025-02-27 14:37:38 |
| Message-ID: | CALDaNm1VRGGOY0eYd02C7ro=s6URmx1R1UwRTW5FDW=a96ea9A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 15 Jan 2025 at 13:21, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> hi.
>
> around src/bin/pg_dump/pg_dump.c line 1117
> right after "ropt->no_comments = dopt.no_comments;"
> we also need add
> ropt->no_policies = dopt.no_policies;
> ?
>
> overall looks good to me.
> The tests seem wrong per
> https://cirrus-ci.com/github/postgresql-cfbot/postgresql/cf%2F5499
> I have no idea how to improve the test.
Here is a rebased version along with the test failure fixes, please
accept the change if you are ok with it.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-pg_dump-pg_dumpall-pg_restore-Add-no-policies-opt.patch | text/x-patch | 11.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2025-02-27 14:40:38 | Patch: Cover POSITION(bytea,bytea) with tests |
| Previous Message | Maxim Orlov | 2025-02-27 14:16:28 | Re: Proposal: Limitations of palloc inside checkpointer |