Re: Virtual generated columns

On Thu, 16 Jan 2025 at 01:16, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 15.01.25 08:11, vignesh C wrote:
> > On Tue, 14 Jan 2025 at 19:08, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> >>
> >>
> >> I've also added a patch that addresses logical replication. It
> >> basically adds back some of the prohibitions against including generated
> >> columns in publications that have been lifted, but this time only for
> >> virtual generated columns, and amends the documentation. It doesn't
> >> rename the publication option "publish_generated_columns", but maybe
> >> that should be done.
> >
> > There are two potential approaches we could take to address the
> > "publish_generated_columns" option: a) We could support multiple
> > values for publish_generated_columns, such as 'none', 'stored', and
> > 'virtual', as Amit suggested in [1]. b) Alternatively, we could rename
> > publish_generated_columns to publish_stored_generated_columns.
> > Both options seem reasonable to me. Do you have a preference for which
> > approach would be better?
>
> I have a very weak preference for a).

Thanks for the suggestion, I have posted a patch for this at [1].
[1] - https://www.postgresql.org/message-id/CALDaNm3OcXdY0EzDEKAfaK9gq2B67Mfsgxu93%2B_249ohyts%3D0g%40mail.gmail.com

Regards,
Vignesh