| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, zzzzz(dot)graf(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18203: Logical Replication initial sync failure |
| Date: | 2023-11-21 18:02:09 |
| Message-ID: | CALDaNm13V3nN5jCO-rr7sZEntJ7NWAsPAA46rskazBPOcCL=ng@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, 21 Nov 2023 at 13:31, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> The v2 patch LGTM except for the commit message.
>
> a) wording - "for tables have no columns too"
> b) the plural of "parenthesis" is "parentheses"
Thanks, these are fixed in the attached v3 version patch.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Specify-parentheses-for-tablesync-worker-copy-com.patch | text/x-patch | 4.4 KB |
| v3-0001-Specify-parentheses-for-tablesync-worker-copy-com_PG15.patch | text/x-patch | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-11-21 18:34:10 | Re: ERROR: value out of range: underflow in numeric log calculation |
| Previous Message | Bruce Momjian | 2023-11-21 14:20:43 | Re: About #13489, array dimensions and CREATE TABLE ... LIKE |