| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "Shinoda, Noriyoshi (SXD Japan FSI)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Michael Paquier <michael(at)paquier(dot)xyz>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com> |
| Subject: | Re: Pgoutput not capturing the generated columns |
| Date: | 2025-01-24 05:06:38 |
| Message-ID: | CALDaNm0zk1vYt2-0rTiKiGYYgq=dfKmkqtVt7dpyFyf_ycr1pw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 24 Jan 2025 at 09:51, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> > On Fri, Jan 24, 2025 at 8:39 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> I think the problem is not so much the underscore as the
> >> inconsistency. You've got "pub", "gen", and "cols" run together,
> >> but then you feel a need to separate "type"?
>
> > It was easy to read and to avoid getting a single word too long.
> > However, I do understand your concern. so will change it to
> > pubgencolstype unless you or someone prefers pubgencols?
>
> I think I'd vote for "pubgencols". I don't see what the "_type"
> suffix is supposed to convey --- there is nothing very type-y about
> this.
I believe simply renaming the catalog column to 'pubgencols' should
suffice. We can keep the internal structure name as 'pubgencols_type'
as it is not exposed, unless you prefer to update it to 'pubgencols'
as well.
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2025-01-24 05:20:59 | Re: Extended Statistics set/restore/clear functions. |
| Previous Message | Shlok Kyal | 2025-01-24 04:22:41 | Re: create subscription with (origin = none, copy_data = on) |