Re: [PoC] Implementation of distinct in Window Aggregates: take two

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>
Cc: Ankit Pandey <itsankitkp(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PoC] Implementation of distinct in Window Aggregates: take two
Date: 2024-02-01 10:49:50
Message-ID: CALDaNm0z1znX0VRM5p9YeRLgsZSQhe0MCm3OQ81baMXC9v2rAw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 8 Nov 2023 at 11:46, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
>
> Hi,
>
> I went through the Cfbot, and some of the test cases are failing for
> this patch. It seems like some tests are crashing:
> https://api.cirrus-ci.com/v1/artifact/task/6291153444667392/crashlog/crashlog-postgres.exe_03b0_2023-11-07_10-41-39-624.txt
>
> [10:46:56.546] Summary of Failures:
> [10:46:56.546]
> [10:46:56.546] 87/270 postgresql:postgres_fdw / postgres_fdw/regress
> ERROR 11.10s exit status 1
> [10:46:56.546] 82/270 postgresql:regress / regress/regress ERROR
> 248.55s exit status 1
> [10:46:56.546] 99/270 postgresql:recovery /
> recovery/027_stream_regress ERROR 161.40s exit status 29
> [10:46:56.546] 98/270 postgresql:pg_upgrade /
> pg_upgrade/002_pg_upgrade ERROR 253.31s exit status 29
>
> link of tests failing:
> https://cirrus-ci.com/task/6642997165555712
> https://cirrus-ci.com/task/4602303584403456
> https://cirrus-ci.com/task/5728203491246080
> https://cirrus-ci.com/task/5165253537824768?logs=test_world#L511
> https://cirrus-ci.com/task/6291153444667392

The patch which you submitted has been awaiting your attention for
quite some time now. As such, we have moved it to "Returned with
Feedback" and removed it from the reviewing queue. Depending on
timing, this may be reversible. Kindly address the feedback you have
received, and resubmit the patch to the next CommitFest.

Regards,
Vignesh

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2024-02-01 11:01:26 Re: [PATCH] Support % wildcard in extension upgrade filenames
Previous Message Amit Kapila 2024-02-01 10:42:43 Re: Synchronizing slots from primary to standby